Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Azure OpenAI embedding provider #702

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

shubhiroy
Copy link

Added support for azure open ai embedding model.

Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍. You should update the configuration-guide.md file to mention this as well. Also, please add a minimal test for this. Thanks!

@shubhiroy shubhiroy closed this Sep 19, 2024
@shubhiroy shubhiroy reopened this Sep 19, 2024
@Pouyanpi Pouyanpi self-requested a review January 9, 2025 13:02
@Pouyanpi Pouyanpi dismissed drazvan’s stale review January 9, 2025 13:07

the change is applied.

@Pouyanpi
Copy link
Collaborator

Pouyanpi commented Jan 9, 2025

@shubhiroy it seems that your PR was pending review for a while, thanks for being patient 👍🏻

Is it possible for you to rebase it to develop branch? I'm not sure if you have noticed but the repo has changed quite significantly since the PR was opened. Also dev workflow has changed a bit (see contributing guide). Let's start by resolving the conflict first.

@Pouyanpi Pouyanpi changed the title chore: Add Azure OpenAI embedding provider feat: Add Azure OpenAI embedding provider Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants