Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility flow wait until done #913

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

sklinglernv
Copy link
Collaborator

Description

Adds a wait until done utility flow into core.co that waits until a flow or action is finished or stopped. This intended to be used whenever the user is interested in whether a flow or action has finished but might miss the Finished() events, e.g. as part of when statements.

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

Copy link
Collaborator Author

@sklinglernv sklinglernv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the naming changes and the split.

But I think the special treatment of flows is not necessary and we should make the CSL example simpler for users to understand (we can keep the test but move it into our unit test folder)

nemoguardrails/colang/v2_x/library/core.co Show resolved Hide resolved
nemoguardrails/colang/v2_x/library/core.co Show resolved Hide resolved
docs/colang-2/examples/test_csl.py Outdated Show resolved Hide resolved
@schuellc-nvidia schuellc-nvidia merged commit 60b9850 into develop Dec 20, 2024
6 checks passed
@schuellc-nvidia schuellc-nvidia deleted the feature/wait-until-done-flow branch December 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants