Better logging + fix for oai system message

Signed-off-by: Igor Gitman <[email protected]>
NVIDIA · Dec 14, 2024 · f16ad00 · f16ad00
1 parent 38fe7f1
commit f16ad00
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/nemo_skills/evaluation/metrics/utils.py b/nemo_skills/evaluation/metrics/utils.py
@@ -23,7 +23,7 @@ def read_predictions(predictions, line_idx, file_handles):
         try:
             prediction_dict = json.loads(prediction)
         except Exception as e:
-            LOG.error(f"Error reading line %s in file %s: %s", line_idx, file_handles[file_idx].name, e)
+            LOG.error(f"Error reading line %s in file %s: %s", line_idx + 1, file_handles[file_idx].name, e)
             raise
         data.append(prediction_dict)
 

diff --git a/nemo_skills/prompt/utils.py b/nemo_skills/prompt/utils.py
@@ -266,14 +266,20 @@ def fill(
             return prompt_string
         else:
             if multi_turn_key is None:
-                messages = [
-                    {"role": "system", "content": self.config.system},
-                    {"role": "user", "content": self.build_user_message(input_dict)},
-                ]
+                if self.config.system:
+                    messages = [
+                        {"role": "system", "content": self.config.system},
+                    ]
+                else:
+                    messages = []
+                messages.append({"role": "user", "content": self.build_user_message(input_dict)})
                 if generation and include_generation:
                     messages.append({"role": "assistant", "content": generation})
             else:
-                messages = [{"role": "system", "content": self.config.system}]
+                if self.config.system:
+                    messages = [{"role": "system", "content": self.config.system}]
+                else:
+                    messages = []
                 for turn in input_dict[multi_turn_key][:-1]:
                     messages.append({"role": "user", "content": self.build_user_message(turn)})
                     messages.append({"role": "assistant", "content": turn["assistant"]})