-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sortformer Diarizer 4spk v1 model PR Part 4: Sortformer Documents and Notebook Tutorials #11707
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Taejin Park <[email protected]>
Signed-off-by: Taejin Park <[email protected]>
Signed-off-by: Taejin Park <[email protected]>
Signed-off-by: Taejin Park <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tango4j, looks great, added minor comments
@@ -213,52 +210,3 @@ The following are descriptions about each field in an input manifest JSON file. | |||
|
|||
TS3012d.Mix-Headset 1 12.879 0.32 okay NA lex MTD046ID | |||
TS3012d.Mix-Headset 1 13.203 0.24 yeah NA lex MTD046ID | |||
|
|||
|
|||
Evaluation on Benchmark Datasets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep a list of benchmark datasets here and maybe a table showcasing the performance of our models on these sets compared to current SOTA?
"!pip install ipython\n", | ||
"\n", | ||
"# ## Install NeMo\n", | ||
"BRANCH = 'main'\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we pin to a release version (or maybe add that as a comment) in case the notebook becomes inconsistent with future main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good and informative tutorial, great work!
What does this PR do ?
This PR adds Sortformer documents and tutorial notebooks.
Collection: ASR/speaker_tasks
Changelog
Speaker Diarization documents.
tutorial/speaker_tasks/End_to_end_Diarization_Training.ipynb
tutorial/speaker_tasks/End_to_end_Diarization_Inference.ipynb
Usage
Run tutorial notebooks.
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information