Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest in CI: changing source of data download to ngc (bionemo2) #498

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pytest in CI: changing source of data download to ngc (bionemo2) #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b809528
changing source of data download in pytest to ngc
dorotat-nv Dec 4, 2024
7032a0c
removing xfail test
dorotat-nv Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/scripts/run_pytest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
set -xueo pipefail
export PYTHONDONTWRITEBYTECODE=1
# NOTE: if a non-nvidia user wants to run the test suite, just run `export BIONEMO_DATA_SOURCE=ngc` prior to this call.
export BIONEMO_DATA_SOURCE="${BIONEMO_DATA_SOURCE:-pbss}"
export BIONEMO_DATA_SOURCE="${BIONEMO_DATA_SOURCE:-ngc}"
source "$(dirname "$0")/utils.sh"

if ! set_bionemo_home; then
Expand Down
8 changes: 1 addition & 7 deletions sub-packages/bionemo-core/tests/bionemo/core/data/test_load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

import pytest

from bionemo.core.data.load import default_ngc_client, default_pbss_client, load
from bionemo.core.data.load import default_pbss_client, load
from bionemo.core.data.resource import get_all_resources


Expand Down Expand Up @@ -269,12 +269,6 @@ def test_default_pbss_client():
assert client.meta.endpoint_url == "https://pbss.s8k.io"


@pytest.mark.xfail(reason="Logging into NGC is not required to download artifacts in BioNeMo.")
def test_default_ngc_client():
clt = default_ngc_client()
assert clt.api_key is not None


@patch("bionemo.core.data.load.default_ngc_client")
def test_load_with_file_from_ngc_model(mocked_get_ngc_client, tmp_path):
(tmp_path / "foo.yaml").write_text(
Expand Down
Loading