Update the Dockerfile with necessary changes from NeMo for H100 self attention accuracy. #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jstjohn
commented
Dec 19, 2024
jstjohn
commented
- Noticed poor accuracy on H100 relative to the same reference model involving flash attention.
- Was able to replicate accuracy on H100 after making these changes to the dockerfile.
…ve good H100 numerical accuracy in flash attention with TE
jstjohn
requested review from
dorotat-nv,
malcolmgreaves,
ohadmo,
pstjohn and
trvachov
as code owners
|
/build-ci |
pstjohn
reviewed
Dec 19, 2024
Signed-off-by: John St. John <[email protected]>
pstjohn
added a commit
that referenced
this pull request
Dec 23, 2024
Cherry picks some additional commits into #550 to see if these also fix CI for 24.10 --------- Signed-off-by: John St. John <[email protected]> Co-authored-by: Farhad Ramezanghorbani <[email protected]> Co-authored-by: John St John <[email protected]> Co-authored-by: John St. John <[email protected]>
Signed-off-by: Peter St. John <[email protected]>
|
Closing since it looks like these edits were all included in the other dockerfile updates |
nvdreidenbach
pushed a commit
to nvdreidenbach/bionemo-framework
that referenced
this pull request
Jan 3, 2025
Cherry picks some additional commits into NVIDIA#550 to see if these also fix CI for 24.10 --------- Signed-off-by: John St. John <[email protected]> Co-authored-by: Farhad Ramezanghorbani <[email protected]> Co-authored-by: John St John <[email protected]> Co-authored-by: John St. John <[email protected]> Signed-off-by: Danny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.