Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MLM loss ignore idx #552

Merged
merged 10 commits into from
Dec 23, 2024
Merged

Fix MLM loss ignore idx #552

merged 10 commits into from
Dec 23, 2024

Conversation

farhadrgh
Copy link
Collaborator

(NOTE: delete these instructional lines as you fill-out this PR template)

(NOTE: _template is designed to be filled-in and used as the squashed commit message for the entire PR. Italicized text is intended to be deleted as you fill in this template. Use the text between the ---)


High level summary of changes. Try to keep this as short and informative as possible: less is more.

Describe your changes. You can be more detailed and descriptive here. If it is a code change, Be sure to answer:

  • What is changing?
  • What is the new or fixed functionality?
  • Why or when would someone want to use these changes?
  • How can someone use these changes?

Summary

High level summary of changes. Try to keep this as short and informative as possible: less is more.

Details

Describe your changes. You can be more detailed and descriptive here.

Usage

How does a user interact with the changed code?

python -m your.new.module -and -all -options

Testing

How do you prove that your code behaves the way you claim?

Tests for these changes can be run via:

pytest -v tests/your/new/or/existing/test_functions.py::test_function

(NOTE: also delete this checklist as you fill-out this PR template)

Most of the changes to files with extensions *.py, *.yaml, *.yml, Dockerfile* or requirements.txt DO REQUIRE both pytest- and jet- CI stages.

@farhadrgh farhadrgh marked this pull request as ready for review December 20, 2024 16:56
@farhadrgh
Copy link
Collaborator Author

/build-ci

@farhadrgh
Copy link
Collaborator Author

/build-ci

@pstjohn pstjohn self-requested a review December 20, 2024 18:21
This reverts commit 2f7eea9, reversing
changes made to e4ebf42.
@farhadrgh
Copy link
Collaborator Author

/build-ci

@farhadrgh farhadrgh enabled auto-merge (squash) December 20, 2024 21:16
@pstjohn
Copy link
Collaborator

pstjohn commented Dec 20, 2024

/build-ci

@pstjohn
Copy link
Collaborator

pstjohn commented Dec 23, 2024

/build-ci

@farhadrgh farhadrgh merged commit c28772b into main Dec 23, 2024
4 checks passed
@farhadrgh farhadrgh deleted the farhadr/ft_bug_ branch December 23, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants