-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add devcontainer prebuild action #70
Conversation
], | ||
"build": { | ||
"dockerfile": "../../Dockerfile", | ||
"cacheFrom": "nvcr.io/nvidian/cvai_bnmo_trng/bionemo:bionemo2-latest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be: nvcr.io/nvidian/cvai_bnmo_trng/bionemo-devcontainer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the right answer to be clear, I am curious about this vs the target defined in prebuild.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, so this isn't quite ready to get merged, mainly testing CI at this point. But eventually, the hope would be that the .devcontainer/devcontainer.json
(i.e., the root one) would point to the pre-built image, while this one inside the .github
folder would build from the included top-level dockerfile. So everytime a new commit got pushed to main, we'd build a new latest
tag, and it would update what folks could quickly pull when they launched the devcontainer setup
Ah ok -- the NGC connectivity might be a red herring: from the detailed job jobs:
we might just be running out of disk space in the github runner |
- uses: devcontainers/[email protected] | ||
with: | ||
configFile: .github/.devcontainer/devcontainer.json | ||
imageName: nvcr.io/nvidian/cvai_bnmo_trng/bionemo-devcontainer | ||
cacheFrom: nvcr.io/nvidian/cvai_bnmo_trng/bionemo-devcontainer | ||
push: filter | ||
eventFilterForPush: push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ohadmo, is this something we could replicate in blossom?
No description provided.