Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document aie .run file when building vgpu manager image #123

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Document aie .run file when building vgpu manager image #123

merged 2 commits into from
Nov 7, 2024

Conversation

cdesiniotis
Copy link
Contributor

@cdesiniotis cdesiniotis commented Nov 6, 2024 •
edited by mikemckiernan
Loading

@cdesiniotis cdesiniotis self-assigned this Nov 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Documentation preview

https://nvidia.github.io/cloud-native-docs/review/pr-123

@mikemckiernan
Finessing and reuse
54696a6 
Signed-off-by: Mike McKiernan <[email protected]>
mikemckiernan
mikemckiernan approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made small tweaks and will leave this open so you have a chance to review. Thanks very much for making the update. I had no idea about the requirement.

gpu-operator/gpu-operator-kubevirt.rst

.. note::

NVIDIA AI Enterprise customers must use the ``aie`` .run file for building the NVIDIA vGPU Manager image.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few small changes like spelling out NVIDIA AI Enterprise. It isn't abbreviated in customer-facing information.

openshift/openshift-virtualization.rst
Unzip the bundle to obtain the NVIDIA vGPU Manager for Linux (``NVIDIA-Linux-x86_64-<version>-vgpu-kvm.run`` file)
Unzip the bundle to obtain the NVIDIA vGPU Manager for Linux file, ``NVIDIA-Linux-x86_64-<version>-vgpu-kvm.run``.

.. include:: ../gpu-operator/gpu-operator-kubevirt.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some trickery. I have a near-end-of-year resolution to set a better example for reusing information.

@cdesiniotis
Copy link
Contributor Author

Thanks @mikemckiernan for the edits. LGTM!

@mikemckiernan mikemckiernan merged commit 2993457 into main Nov 7, 2024
2 checks passed
@mikemckiernan mikemckiernan deleted the nvaie-runfile branch November 7, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemckiernan mikemckiernan mikemckiernan approved these changes

@tariq1890 tariq1890 Awaiting requested review from tariq1890

Assignees

@cdesiniotis cdesiniotis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdesiniotis @mikemckiernan