Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noise model enhancements #2168

Merged
merged 26 commits into from
Sep 30, 2024
Merged

Conversation

1tnguyen
Copy link
Collaborator

@1tnguyen 1tnguyen commented Aug 28, 2024

Description

(1) Noise model enhancements

  • Support a match-all condition (noise on a gate, any qubits)

  • Support noise defined via callback functions.

(2) Noise mapping for custom operations

  • Move the custom operation map to the common/ location so that it can be accessed from anywhere.

  • Make the registration a bit earlier so that we know that an operation is registered before actually running that gate.

  • Connect the Python registration to C++.

  • Propagate the custom op name all the way back to the runtime, i.e., simulator.

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 28, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 28, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 29, 2024
- For the path via ExecutionManager: making sure the registration is
  early enough, i.e., at the point of registration.

- For the Python path: need to let the registry know about the
  registration.

- Propagate the custom op name all the way to the simulator.
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 30, 2024
@1tnguyen 1tnguyen marked this pull request as ready for review August 30, 2024 04:51
@1tnguyen 1tnguyen requested review from amccaskey and khalatepradnya and removed request for amccaskey and khalatepradnya August 30, 2024 04:51
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Copy link
Collaborator

@khalatepradnya khalatepradnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Thanks, Thien!
I reviewed the tests, refactoring for custom operations, and Python bindings. (I defer on the specifics of the implementation.)
nit: Do we need a C++ example as well?

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
Copy link
Collaborator

@khalatepradnya khalatepradnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍🏽

@1tnguyen
Copy link
Collaborator Author

These changes look good to me. Thanks, Thien! I reviewed the tests, refactoring for custom operations, and Python bindings. (I defer on the specifics of the implementation.) nit: Do we need a C++ example as well?

Thanks @khalatepradnya. I added a C++ example in 01130bd, which is similar to the Python example that I added.

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
github-actions bot pushed a commit that referenced this pull request Sep 27, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 27, 2024
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
@1tnguyen 1tnguyen merged commit a4d318f into NVIDIA:main Sep 30, 2024
129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants