-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noise model enhancements #2168
Noise model enhancements #2168
Conversation
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
- For the path via ExecutionManager: making sure the registration is early enough, i.e., at the point of registration. - For the Python path: need to let the registry know about the registration. - Propagate the custom op name all the way to the simulator.
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. Thanks, Thien!
I reviewed the tests, refactoring for custom operations, and Python bindings. (I defer on the specifics of the implementation.)
nit: Do we need a C++ example as well?
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍🏽
Thanks @khalatepradnya. I added a C++ example in 01130bd, which is similar to the Python example that I added. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Description
(1) Noise model enhancements
Support a match-all condition (noise on a gate, any qubits)
Support noise defined via callback functions.
(2) Noise mapping for custom operations
Move the custom operation map to the
common/
location so that it can be accessed from anywhere.Make the registration a bit earlier so that we know that an operation is registered before actually running that gate.
Connect the Python registration to C++.
Propagate the custom op name all the way back to the runtime, i.e., simulator.