Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct eeprom customer part number handling #34

Open
wants to merge 1 commit into
base: r35.2.1-updates
Choose a base branch
from

Conversation

jgarver
Copy link
Contributor

@jgarver jgarver commented Feb 3, 2023

Ensure customer part number format is supported in all part number processing paths.

Fixes #33

Signed-off-by: Bob Morgan [email protected]
Tested-by: Ashish Singhal [email protected]
Reviewed-by: Ashish Singhal [email protected]

Ensure customer part number format is supported in all
part number processing paths.

Fixes #33

Signed-off-by: Bob Morgan <[email protected]>
Tested-by: Ashish Singhal <[email protected]>
Reviewed-by: Ashish Singhal <[email protected]>
@kekiefer
Copy link

This is working for me, thanks!

kekiefer added a commit to kekiefer/meta-tegra that referenced this pull request Feb 14, 2023
In the port of this patch, the customer prefix was erroneously
dropped from the population of customer board ids in the chosen
devicetree node:

2888-0004-400 0123-123

Should read as:

2888-0004-400 ABCD-0123-123

The master branch of edk2-firmware contains a rewritten version
that works correctly, so update to this version. A PR for update
to 35.2.1 happened upstream around the time of the release:

NVIDIA/edk2-nvidia#34
kekiefer added a commit to kekiefer/meta-tegra that referenced this pull request Feb 14, 2023
In the port of this patch, the customer prefix was erroneously
dropped from the population of customer board ids in the chosen
devicetree node:

  # cat /sys/firmware/devicetree/base/chosen/ids
  2888-0004-400 0123-123

Should read as:

  # cat /sys/firmware/devicetree/base/chosen/ids
  2888-0004-400 ABCD-0123-123

The master branch of edk2-firmware contains a rewritten version
that works correctly, so update to this version. A PR for update
to 35.2.1 happened upstream around the time of the release:

NVIDIA/edk2-nvidia#34

Signed-off-by: Kurt Kiefer <[email protected]>
kekiefer added a commit to kekiefer/meta-tegra that referenced this pull request Feb 14, 2023
In the port of this patch, the customer prefix was erroneously
dropped from the population of customer board ids in the chosen
devicetree node:

    # cat /sys/firmware/devicetree/base/chosen/ids
    2888-0004-400 0123-123

Should read as:

    # cat /sys/firmware/devicetree/base/chosen/ids
    2888-0004-400 ABCD-0123-123

The master branch of edk2-firmware contains a rewritten version
that works correctly, so update to this version. A PR for update
to 35.2.1 happened upstream around the time of the release:

NVIDIA/edk2-nvidia#34

Signed-off-by: Kurt Kiefer <[email protected]>
madisongh pushed a commit to OE4T/meta-tegra that referenced this pull request Feb 15, 2023
In the port of this patch, the customer prefix was erroneously
dropped from the population of customer board ids in the chosen
devicetree node:

    # cat /sys/firmware/devicetree/base/chosen/ids
    2888-0004-400 0123-123

Should read as:

    # cat /sys/firmware/devicetree/base/chosen/ids
    2888-0004-400 ABCD-0123-123

The master branch of edk2-firmware contains a rewritten version
that works correctly, so update to this version. A PR for update
to 35.2.1 happened upstream around the time of the release:

NVIDIA/edk2-nvidia#34

Signed-off-by: Kurt Kiefer <[email protected]>
madisongh pushed a commit to OE4T/meta-tegra that referenced this pull request Feb 15, 2023
In the port of this patch, the customer prefix was erroneously
dropped from the population of customer board ids in the chosen
devicetree node:

    # cat /sys/firmware/devicetree/base/chosen/ids
    2888-0004-400 0123-123

Should read as:

    # cat /sys/firmware/devicetree/base/chosen/ids
    2888-0004-400 ABCD-0123-123

The master branch of edk2-firmware contains a rewritten version
that works correctly, so update to this version. A PR for update
to 35.2.1 happened upstream around the time of the release:

NVIDIA/edk2-nvidia#34

Signed-off-by: Kurt Kiefer <[email protected]>
madisongh pushed a commit to OE4T/meta-tegra that referenced this pull request Feb 15, 2023
In the port of this patch, the customer prefix was erroneously
dropped from the population of customer board ids in the chosen
devicetree node:

    # cat /sys/firmware/devicetree/base/chosen/ids
    2888-0004-400 0123-123

Should read as:

    # cat /sys/firmware/devicetree/base/chosen/ids
    2888-0004-400 ABCD-0123-123

The master branch of edk2-firmware contains a rewritten version
that works correctly, so update to this version. A PR for update
to 35.2.1 happened upstream around the time of the release:

NVIDIA/edk2-nvidia#34

Signed-off-by: Kurt Kiefer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants