Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Micrel (now Microchip) KSZ9031 1G RGMII Ethernet PHY #66

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pnewman-cti
Copy link
Contributor

This patch adds support for the Micrel (now Microchip) KSZ9031 1G RGMII
Ethernet PHY used on many Connect Tech carrier boards to the NNIDIA Eqos UEFI Driver.

Signed-off-by: Parker Newman [email protected]

…t PHY

This patch adds support for the Micrel (now Microchip) KSZ9031 1G RGMII
Ethernet PHY used on many Connect Tech carrier boards to the NNIDIA Eqos UEFI Driver.

Signed-off-by: Parker Newman <[email protected]>
@jbrasen jbrasen self-assigned this Jul 25, 2023
Copy link
Contributor

@jbrasen jbrasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. This looks good. Working on pulling it in to our internal repo now.

@pnewman-cti
Copy link
Contributor Author

Thanks!

@pnewman-cti
Copy link
Contributor Author

@jbrasen I have a minor edit to this patch. Should I amend this pull request or open a new one?

This patch sovles an autonegotion advertisement issue that can occur
with the Micrel KSZ9031 that prevents the link coming up in UEFI

Signed-off-by: Parker Newman <[email protected]>
@pnewman-cti
Copy link
Contributor Author

I added the new patch to this request.

The KSZ9031 has a bug where it will stop working if the Idle Error
count is maxed out. This can occur on power up on systems without
ethernet magnetics and requires a soft reset if it occurs.

This patch adds an Idle Error check and soft reset based on the Linux
driver.

Signed-off-by: Parker Newman <[email protected]>
@pnewman-cti
Copy link
Contributor Author

@jbrasen I have added a 2nd small patch to this branch. Can you please ensure they both get added along with the main driver? Thank you

@jbrasen
Copy link
Contributor

jbrasen commented Sep 8, 2023

Yes will work on pulling these two in. The main driver should be there now.

@jbrasen jbrasen added the In Internal Review In review in nvidia internal process label Sep 8, 2023
@jbrasen jbrasen added Pending Next Release Code is in interal repo pending next public release and removed In Internal Review In review in nvidia internal process labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending Next Release Code is in interal repo pending next public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants