feat: Add UEFI Adapter Information Protocol Support #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the UEFI Adapter Information Protocol (AIP) for Nvidia Ethernet controllers. This fixes an issue where PXE does not load if the network interface is not ready (MediaPresent) when the PXE driver starts. Without AIP support NetLibDetectMediaWaitTimeout() will check if the network interface is ready only once. If it is not then it cancels PXE boot. This means if the network interface is slow to link the system will not attempt to PXE boot. When AIP support is availible NetLibDetectMediaWaitTimeout() will poll for "MediaPresent" to be "TRUE" or until it times out. Based on: edk2-platforms/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/ Found at: https://github.com/tianocore/edk2-platforms/ Signed-off-by: Parker Newman <[email protected]>
jbrasen
added
In Internal Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the UEFI Adapter Information Protocol (AIP) for Nvidia
Ethernet controllers. This fixes an issue where PXE does not load if
the network interface is not ready (MediaPresent) when the PXE driver starts.
Without AIP support NetLibDetectMediaWaitTimeout() will check if the network
interface is ready only once. If it is not then it cancels PXE boot. This
means if the network interface is slow to link the system will not attempt
to PXE boot.
When AIP support is availible NetLibDetectMediaWaitTimeout() will poll for
"MediaPresent" to be "TRUE" or until it times out.
Based on: edk2-platforms/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/
Found at: https://github.com/tianocore/edk2-platforms/
Signed-off-by: Parker Newman [email protected]