Fix build and tests targets on darwin #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
test-on-darwin
branch
from
4222c8d to
654a673
Compare
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
test-on-darwin
branch
from
654a673 to
772cf77
Compare
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Sep 26, 2024
The previous commit explains how the NVIDIA Container Toolkit is
sensitive to some linker flags. Therefore, use the same linker flags
that are used by NVIDIA Container Toolkit to build the nvidia-cdi-hook,
nvidia-ctk, etc. binaries, because they use the same Go APIs that
toolbox(1) does [1]. It's better to use the same build configuration to
prevent subtle bugs from creeping in.
[1] NVIDIA Container Toolkit commit 772cf77dcc2347ce
NVIDIA/nvidia-container-toolkit@772cf77dcc2347ce
NVIDIA/nvidia-container-toolkit#333
containers#1548
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the build and test targets to run successfully on Darwin.