Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to set per-container features in the config file #743

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

elezar
Copy link
Member

@elezar elezar commented Oct 16, 2024

This change removes the ability to set the per-container opt-in features for GDS and MOFED, for example.

This functionality added in #362 was not publicly documented.

@elezar elezar requested a review from klueska October 16, 2024 13:06
@elezar elezar self-assigned this Oct 16, 2024
@elezar elezar force-pushed the remove-opt-in-features branch from ac6f785 to ca06a98 Compare October 16, 2024 13:08
This change REMOVES the ability to set opt-in features
(e.g. GDS, MOFED, GDRCOPY) in the config file. The existing
per-container envvars are unaffected.

Signed-off-by: Evan Lezar <[email protected]>
@elezar elezar force-pushed the remove-opt-in-features branch from ca06a98 to 1d9d0ac Compare October 16, 2024 13:30
@elezar elezar merged commit ec8dfaf into NVIDIA:main Oct 17, 2024
10 checks passed
@elezar elezar deleted the remove-opt-in-features branch October 17, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants