Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for specialized dispatch changes in row hasher #2133

Open
wants to merge 3 commits into
base: branch-24.10
Choose a base branch
from

Conversation

tgujar
Copy link

@tgujar tgujar commented Jun 10, 2024

device_row_hasher has an additional template argument as specified in this cudf PR. This PR aims to fix build fails due to this breaking change. It does not change the program behavior.

@tgujar tgujar changed the title [WIP] fix for specialized dispatch changes in row hasher Fix for specialized dispatch changes in row hasher Jun 12, 2024
@tgujar tgujar marked this pull request as ready for review June 12, 2024 15:33
@sameerz sameerz requested review from revans2 and nvdbaranec June 24, 2024 20:39
revans2
revans2 previously approved these changes Jun 24, 2024
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for when the CUDF changes happen.

@mattahrens
Copy link
Collaborator

Please retarget to 24.10.

@tgujar tgujar changed the base branch from branch-24.08 to branch-24.10 July 31, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants