-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xxhash64
support for nested types
#2575
Conversation
xxhash64
support for nested types
Please add more cases, LGTM for the function. |
LGTM |
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but I am no expert on the CUDA side of things.
cudf::size_type row_index) const noexcept | ||
{ | ||
if (_check_nulls && col.is_null(row_index)) { return _seed; } | ||
return XXHash_64<T>{_seed}(col.element<T>(row_index)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a follow on issue to make the hash function a template? We have the same issues with all hash functions we want to support, so having generic code would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me, but a nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this PR has similar implementation with the HiveHash one, so both need to address the issue with shallow stack size unless we want to target this for 24.12.
Signed-off-by: ustcfy <[email protected]>
Signed-off-by: ustcfy <[email protected]>
Co-authored-by: Chong Gao <[email protected]>
Signed-off-by: ustcfy <[email protected]>
Co-authored-by: Chong Gao <[email protected]>
Signed-off-by: ustcfy <[email protected]>
940e5c9
to
2bb3c60
Compare
Signed-off-by: Yan Feng <[email protected]>
Co-authored-by: Nghia Truong <[email protected]>
build |
Signed-off-by: Yan Feng <[email protected]>
Co-authored-by: Nghia Truong <[email protected]>
Spark-Rapids PR verified the correctness, we can merge it. |
build |
Contribute to #2574
This PR adds support for
xxhash64
withstruct
,list
andmap
types.The hardcoded expected values in the tests are generated using Spark.
For example, you can produce the same results as in
testXXHash64ListOfStruct
using the following code.You will get the following output: