Move Support for RaiseError to a Shim Excluding Spark 4.0.0 [databricks]
#10970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <[email protected]>
|
build |
|
The change here is easy enough to understand. But the description in neither this PR nor #10969 links to the change in Apache Spark 4.0 that breaks compatibility. Would you mind adding a link to the change, so that the reviewer doesn't have to hunt for the breakage? Edit: Is the following issue the relevant one?
|
|
Thanks for pointing that out @mythrocks and linking the issues here. I have updated the description. |
SurajAralihalli
pushed a commit
to SurajAralihalli/spark-rapids
that referenced
this pull request
Jul 12, 2024
…icks] (NVIDIA#10970) * Incomplete impl of RaiseError for 400 * Removed RaiseError from 400 * Signing off Signed-off-by: Raza Jafri <[email protected]> --------- Signed-off-by: Raza Jafri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the support for RaiseError to a shim because Spark 4.0.0 has changed the way they throw exceptions here
The feature to add support for it to Spark 4.0 is tracked by #10969 issue and #10107
contributes to #10969
contributes to #10107