Drop spark-3.1.x support for spark-rapids #11041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI part for the issue: NVIDIA#10955 We'll drop spark-3.1.x support from branch-24.08, change the default spark version string to 3.2.0 This change needs to work together with the source code update for dropping spark-3.1.x support Will keep monitoring CI jobs status after all the related changes get merged Signed-off-by: Tim Liu <[email protected]>
NvTimLiu
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008 and
gerashegalov
as code owners
|
Draft the PR, because this change needs to work together with the source code update for dropping spark-3.1.x support |
Signed-off-by: Tim Liu <[email protected]>
|
build |
pxLi
reviewed
Jul 3, 2024
| @@ -32,7 +32,7 @@ CUDA_CLASSIFIER=${CUDA_CLASSIFIER:-"cuda11"} | |||
| CLASSIFIER=${CLASSIFIER:-"$CUDA_CLASSIFIER"} # default as CUDA_CLASSIFIER for compatibility | |||
| PROJECT_VER=${PROJECT_VER:-"24.08.0-SNAPSHOT"} | |||
| PROJECT_TEST_VER=${PROJECT_TEST_VER:-"24.08.0-SNAPSHOT"} | |||
| SPARK_VER=${SPARK_VER:-"3.1.1"} | |||
| SPARK_VER=${SPARK_VER:-"3.2.0"} | |||
| SPARK_VER_213=${SPARK_VER_213:-"3.3.0"} | |||
There was a problem hiding this comment.
BTW do you know if anyone relies on the SPARK_VER_213 somewhere? it seems an unused one
There was a problem hiding this comment.
Yes seems it's unused
|
can you also help remove 31x https://github.com/NVIDIA/spark-rapids/blob/branch-24.08/pom.xml#L866 from the test list? thanks |
|
Drop this, replaced by #11159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI part for the issue: #10955
We'll drop spark-3.1.x support from branch-24.08, change the default spark version string to 3.2.0
This change needs to work together with the source code update for dropping spark-3.1.x support
Will keep monitoring CI jobs status after all the related changes get merged