-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix collection_ops_tests
for Spark 4.0 [databricks]
#11414
Merged
mythrocks
merged 10 commits into
NVIDIA:branch-24.12
from
mythrocks:spark4-collection-ops-tests
Oct 12, 2024
Merged
Fix collection_ops_tests
for Spark 4.0 [databricks]
#11414
mythrocks
merged 10 commits into
NVIDIA:branch-24.12
from
mythrocks:spark4-collection-ops-tests
Oct 12, 2024
Commits on Aug 30, 2024
-
Fix collection_ops_tests for Spark 4.0.
Fixes NVIDIA#11011. This commit fixes the failures in `collection_ops_tests` on Spark 4.0. On all versions of Spark, when a Sequence is collected with rows that exceed MAX_INT, an exception is thrown indicating that the collected Sequence/array is larger than permissible. The different versions of Spark vary in the contents of the exception message. On Spark 4, one sees that the error message now contains more information than all prior versions, including: 1. The name of the op causing the error 2. The errant sequence size This commit introduces a shim to make this new information available in the exception. Note that this shim does not fit cleanly in RapidsErrorUtils, because there are differences within major Spark versions. For instance, Spark 3.4.0-1 have a different message as compared to 3.4.2 and 3.4.3. Likewise, the differences in 3.5.0, 3.5.1, 3.5.2. Signed-off-by: MithunR <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b8bd960 - Browse repository at this point
Copy the full SHA b8bd960View commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ee2eb81 - Browse repository at this point
Copy the full SHA ee2eb81View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1037b69 - Browse repository at this point
Copy the full SHA 1037b69View commit details
Commits on Sep 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3bcf04f - Browse repository at this point
Copy the full SHA 3bcf04fView commit details
Commits on Sep 28, 2024
-
This moves the construction of the long-sequence error strings into RapidsErrorUtils. The process involved introducing many new RapidsErrorUtils classes, and using mix-ins of concrete implementations for the error-string construction.
Configuration menu - View commit details
-
Copy full SHA for 2427bf3 - Browse repository at this point
Copy the full SHA 2427bf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc4ae45 - Browse repository at this point
Copy the full SHA cc4ae45View commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9798684 - Browse repository at this point
Copy the full SHA 9798684View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bfac65 - Browse repository at this point
Copy the full SHA 0bfac65View commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fe704af - Browse repository at this point
Copy the full SHA fe704afView commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4ae9e68 - Browse repository at this point
Copy the full SHA 4ae9e68View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.