Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection_ops_test for [databricks] 14.3 #11623

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

mythrocks
Copy link
Collaborator

Fixes #11532.

This commit introduces a RapidsErrorUtils shim for Databricks 14.3, to deal with the new error messages thrown for large array/sequences.

This should fix the failure in collection_ops_test.py::test_sequence_too_long_sequence on Databricks 14.3.

@mythrocks mythrocks self-assigned this Oct 17, 2024
@mythrocks mythrocks force-pushed the db-14.3-collect-ops-test branch 2 times, most recently from d06f1c2 to 2a72a4c Compare October 18, 2024 17:21
Fixes NVIDIA#11532.

This commit introduces a RapidsErrorUtils shim for Databricks 14.3, to
deal with the new error messages thrown for large array/sequences.

This should fix the failure in `collection_ops_test.py::test_sequence_too_long_sequence`
on Databricks 14.3.

Signed-off-by: MithunR <[email protected]>
@mythrocks
Copy link
Collaborator Author

Build

@sameerz sameerz added the task Work required that improves the product but is not user facing label Oct 19, 2024
@mythrocks
Copy link
Collaborator Author

Build

Copy link
Collaborator

@razajafri razajafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mythrocks mythrocks merged commit 732b25b into NVIDIA:branch-24.12 Oct 22, 2024
45 checks passed
@mythrocks
Copy link
Collaborator Author

Thank you for the review, @razajafri. I've merged this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Collections tests on Databricks 14.3
3 participants