Topograph model import for use with toposim #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t models Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
…el file Signed-off-by: Henry Haase <[email protected]>
…osim Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
dmitsh
requested changes
Oct 25, 2024
Signed-off-by: Dmitry Shmulevich <[email protected]>
…ameter. Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
dmitsh
approved these changes
Oct 25, 2024
pkedy
reviewed
Oct 25, 2024
| } else { | ||
| model, err := models.NewModelFromFile(modelPath) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
nit: You unless properly wrapped by models.NewModelFromFile, you'll want to wrap this error with
fmt.Errorf("could not read model file: %w", err)If models.NewModelFromFile(modelPath) DOES wrap the error, I would just add a comment
return nil, err // Wrapped by models.NewModelFromFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds functionality for topograph to import a cluster model from a file to be use with toposim.