-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require metadata on all topology #26
Conversation
… topology Signed-off-by: Henry Haase <[email protected]>
Two comments regarding this PR, the first of which is: If the topology request payload specifies a topology plugin (either tree or block) that is different than the topology that can be provided, what should be the action? Return an error in the request? |
And second, for MNNVL, is block topology always returned (current implementation), or should tree topology be returned in some situations? |
Toposim (and GTS) returns a collections of nodes with their local topology (a chain of switches and/or presence of nvlink). |
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Signed-off-by: Henry Haase <[email protected]>
Requires metadata to be set on all topology, including both tree and block topology.