Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS arm64 support and various other fixes #569

Open
wants to merge 3 commits into
base: 4.1
Choose a base branch
from

Conversation

dpogue
Copy link

@dpogue dpogue commented Jun 4, 2022

By default this will make a macOS universal build (with both x86_64 and arm64 in the same files) but supports per-architecture builds using the CMake PX_OUTPUT_ARCH flag.

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dpogue
❌ Lunanne
You have signed the CLA already but the status is still pending? Let us recheck it.

@MissUp109
Copy link

MissUp109 commented Jun 4, 2022 via email

@colincornaby
Copy link

Building this for ARM64/macOS and getting the following error:

/Users/colincornaby/Documents/Plasma/PlasmaSrc/vcpkg/buildtrees/physx/src/be49a99479-d1b16eed08.clean/physx/source/foundation/include/unix/neon/PsUnixNeonInlineAoS.h:3582:10: error: argument value 2 is outside the valid range [0, 1]
                return vdupq_lane_f32(vget_low_f32(a), index);

The code looks like this:

#if PX_UWP
	if(index == 0)
	{
		return vdupq_lane_f32(vget_low_f32(a), 0);
	}
	else if (index == 1)
	{
		return vdupq_lane_f32(vget_low_f32(a), 1);
	}
#else
	if(index < 2)
	{
		return vdupq_lane_f32(vget_low_f32(a), index);
	}
#endif

The issue could probably be resolved by opting in to the UWP behavior. I'm not sure what the source of this issue is - it should be happening for iOS as well. It could be that Apple has added this enforcement in a compiler update at some point.

@MissUp109
Copy link

MissUp109 commented Aug 25, 2022 via email

@dpogue
Copy link
Author

dpogue commented Aug 25, 2022

I'm not sure what the source of this issue is - it should be happening for iOS as well. It could be that Apple has added this enforcement in a compiler update at some point.

I remember seeing this somewhere, but do not recall how I worked around it and why it didn't block submitting this patch (or the acceptance of this patch into other packaging systems) 😕

@rustui
Copy link

rustui commented Oct 2, 2022

This patch fixes compilation error.

@MissUp109
Copy link

MissUp109 commented Oct 2, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants