Add CUDA Healpix pad routines #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbren12
requested changes
Aug 7, 2024
There was a problem hiding this comment.
Great work @daviddpruitt. A couple of requests:
- fix CPU-only use. The library should be installable without a GPU/CUDA installation.
- harmonize the various python healpixpad interfaces (see comment below).
setup.py
Outdated
| @@ -63,7 +67,12 @@ def get_compiler(): | |||
| src_files, | |||
| extra_compile_args=extra_compile_args, | |||
| include_dirs=[os.path.abspath("earth2grid/csrc"), os.path.abspath("earth2grid/third_party/healpix_bare")], | |||
| ) | |||
| ), | |||
| cpp_extension.CUDAExtension( | |||
There was a problem hiding this comment.
Can you add a check to only include this extension if cuda is present?
|
Thanks @daviddpruitt! I fixed the issue with the CI. The build was failing since CUDA is not installed in GitHub actions. |
|
I think the matplotlib issue is fixed in #10, so will go ahead and merge. The test pass on my laptop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Cuda padding routines for healpix xy grids so they don't have to be installed as a separate package.