No ref/phase 3 endpoints #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EdwinGuzman
requested changes
Dec 3, 2024
There was a problem hiding this comment.
I think the endpoints should be grouped as app/api/schema/.... Makes it easier to differentiate whether it's an endpoint for the app to use or for schema collaboration purposes. It might also make it easier to write the regex in the reverse proxy repo as a catch-all for all these schema endpoints.
7emansell
reviewed
Dec 5, 2024
| import searchSchema from "../../src/data/schemas/searchSchema"; | ||
|
|
||
| export const GET = async () => { | ||
| return NextResponse.json(searchSchema, { status: 200 }); |
There was a problem hiding this comment.
I'm not sure I understand how status is working in this setup. Does this mean it would live on the response (like we've been talking about) instead of within the headers field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.