rm argument from isUnfamiliarPatronType

NYPL · Dec 19, 2024 · 307d70b · 307d70b
1 parent 0416945
commit 307d70b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/lib/available_delivery_location_types.js b/lib/available_delivery_location_types.js
@@ -9,7 +9,7 @@ class AvailableDeliveryLocationTypes {
 
     return this._getPatronTypeOf(patronID)
       .then((patronType) => {
-        if (this._isUnfamiliarPatronType(nyplCore.patronTypes(), patronType)) {
+        if (this._isUnfamiliarPatronType(patronType)) {
           return
         }
         const patronTypeData = nyplCore.patronTypes()[patronType]
@@ -38,8 +38,8 @@ class AvailableDeliveryLocationTypes {
     })
   }
 
-  static _isUnfamiliarPatronType (patronTypes, patronType) {
-    if (!patronTypes[patronType]) {
+  static _isUnfamiliarPatronType (patronType) {
+    if (!nyplCore.patronTypes()[patronType]) {
       logger.info(`Found the Patron Type: ${patronType} is not recognizable.`)
       return true
     } else {

diff --git a/test/available_delivery_location_types.test.js b/test/available_delivery_location_types.test.js
@@ -1,8 +1,7 @@
 const fixtures = require('./fixtures')
+const AvailableDeliveryLocationTypes = require('../lib/available_delivery_location_types.js')
 
 describe('AvailableDeliveryLocationTypes', function () {
-  const AvailableDeliveryLocationTypes = require('../lib/available_delivery_location_types.js')
-
   before(function () {
     // Reroute these (and only these) api paths to local fixtures:
     fixtures.enableDataApiFixtures({