Skip to content

Commit

Permalink
tests for phys requestable override
Browse files Browse the repository at this point in the history
  • Loading branch information
@charmingduchess
charmingduchess committed Dec 20, 2024
1 parent 7877170 commit ea70169
Show file tree
Hide file tree
Showing 4 changed files with 312 additions and 287 deletions.
2 changes: 1 addition & 1 deletion lib/requestability_resolver.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class RequestabilityResolver {
}
item.specRequestable = this.buildSpecRequestable(item, parentBibHasFindingAid)
item.physRequestable = !!deliveryInfo.deliveryLocation?.length
item.eddRequestable = !!deliveryInfo.eddRequestable && !item.specRequestable
item.eddRequestable = !!deliveryInfo.eddRequestable
// items without barcodes should not be requestable
const hasBarcode = (item.identifier || []).some((identifier) => /^(urn|bf):[bB]arcode:\w+/.test(identifier))
if (isItemNyplOwned(item) && !hasBarcode) {
Expand Down
287 changes: 1 addition & 286 deletions test/fixtures/specRequestable/findingAid-es-response.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,173 +17,7 @@ module.exports = () => {
label: 'Finding aid',
url: 'spaghetti.com'
}],
numItems: [
4
],
createdString: [
'1989'
],
issuance: [
{
label: 'monograph/item',
id: 'urn:biblevel:m'
}
],
creatorLiteral: [
'Maḥfūẓ, Najīb, 1911-2006.'
],
creator_sort: [
'maḥfūẓ, najīb, 1911-2006.'
],
level: 'debug',
items: [
{
uri: 'i22566485',
identifier: [
'urn:barcode:33433058338470'
],
status: [
{
label: 'Available',
id: 'status:a'
}
]
},
{
uri: 'i22566489'
},
{
holdingLocation_packed: [
'loc:scff2||Schomburg Center - Research & Reference'
],
suppressed: [
false
],
shelfMark: [
'Sc D 90-863'
],
accessMessage_packed: [
'accessMessage:1||USE IN LIBRARY'
],
uri: 'i10283665',
accessMessage: [
{
label: 'USE IN LIBRARY',
id: 'accessMessage:1'
}
],
catalogItemType: [
{
id: 'catalogItemType:2',
label: 'book non-circ'
}
],
deliveryLocation_packed: [
'loc:sc||Schomburg Center'
],
owner: [
{
label: 'Schomburg Center for Research in Black Culture, Jean Blackwell Hutson Research and Reference Division',
id: 'orgs:1114'
}
],
deliveryLocation: [
{
label: 'Schomburg Center',
id: 'loc:sc'
}
],
identifier: [
'urn:barcode:32101071572406'
],
requestable: [
true
],
owner_packed: [
'orgs:1114||Schomburg Center for Research in Black Culture, Jean Blackwell Hutson Research and Reference Division'
],
status: [
{
label: 'Available',
id: 'status:a'
}
],
holdingLocation: [
{
label: 'Schomburg Center - Research & Reference',
id: 'loc:scff2'
}
],
status_packed: [
'status:a||Available'
]
},
{
holdingLocation_packed: [
'loc:scff2||Schomburg Center - Research & Reference'
],
suppressed: [
false
],
shelfMark: [
'Sc D 90-863'
],
accessMessage_packed: [
'accessMessage:1||USE IN LIBRARY'
],
uri: 'i10283665777',
accessMessage: [
{
label: 'USE IN LIBRARY',
id: 'accessMessage:1'
}
],
catalogItemType: [
{
id: 'catalogItemType:2',
label: 'book non-circ'
}
],
deliveryLocation_packed: [
'loc:sc||Schomburg Center'
],
owner: [
{
label: 'Schomburg Center for Research in Black Culture, Jean Blackwell Hutson Research and Reference Division',
id: 'orgs:1114'
}
],
deliveryLocation: [
{
label: 'Schomburg Center',
id: 'loc:sc'
}
],
identifier: [
'urn:barcode:32101071572406777'
],
requestable: [
true
],
owner_packed: [
'orgs:1114||Schomburg Center for Research in Black Culture, Jean Blackwell Hutson Research and Reference Division'
],
status: [
{
label: 'Not Available',
id: 'status:na'
}
],
holdingLocation: [
{
label: 'Schomburg Center - Research & Reference',
id: 'loc:mao82'
}
],
status_packed: [
'status:na||Not Available'
]
},
{
holdingLocation: [
{
Expand Down Expand Up @@ -304,127 +138,8 @@ module.exports = () => {
false
]
}
],
message: 'ResourceSerializer#serialize',
materialType_packed: [
'resourcetypes:txt||Text'
],
suppressed: [
'false'
],
placeOfPublication: [
'New York :'
],
dateEndString: [
'1984'
],
title_sort: [
'the thief and the dogs'
],
uris: [
'b11293188',
'b11293188-i22566485',
'b11293188-i22566489',
'b11293188-i10283665',
'b11293188-i10283664'
],
language: [
{
id: 'lang:eng',
label: 'English'
}
],
dateString: [
'1989'
],
identifier: [
'urn:bnum:11293188',
'urn:oclc:12248278',
'urn:lcc:PJ7846.A46',
'urn:lccCoarse:PJ7695.8-7976'
],
publisher: [
'Doubleday,'
],
type: [
'nypl:Item'
],
createdYear: [
1989
],
contributor_sort: [
'badawī, muḥammad muṣṭafá.'
],
materialType: [
{
id: 'resourcetypes:txt',
label: 'Text'
}
],
numAvailable: [
2
],
dimensions: [
'22 cm.'
],
carrierType_packed: [
'carriertypes:nc||volume'
],
note: [
'Translation of: al-Liṣṣ wa-al-kilāb.'
],
dateStartYear: [
1989
],
shelfMark: [
'*OFC 90-2649'
],
idOwi: [
'urn:owi:58201773'
],
mediaType: [
{
label: 'unmediated',
id: 'mediatypes:n'
}
],
title: [
'The thief and the dogs',
'The thief and the dogs /'
],
titleAlt: [
'Liṣṣ wa-al-kilāb.'
],
language_packed: [
'lang:eng||English'
],
mediaType_packed: [
'mediatypes:n||unmediated'
],
titleDisplay: [
'The thief and the dogs / Naguib Mahfouz ; translated by Trevor Le Gassick, M.M. Badawi ; revised by John Rodenbeck.'
],
uri: 'b11293188',
extent: [
'158 p. ;'
],
carrierType: [
{
id: 'carriertypes:nc',
label: 'volume'
}
],
issuance_packed: [
'urn:biblevel:m||monograph/item'
],
contributorLiteral: [
'Badawī, Muḥammad Muṣṭafá.',
'Le Gassick, Trevor.',
'Rodenbeck, John.'
],
dateEndYear: [
1984
]

},
_type: 'resource',
_index: 'resources-2017-06-13',
Expand Down
Loading

0 comments on commit ea70169

Please sign in to comment.