fixing one issue

NYPL · Oct 29, 2024 · 9a6ccea · 9a6ccea
1 parent 59e3a8d
commit 9a6ccea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/processes/frbr/classify.py b/processes/frbr/classify.py
@@ -84,11 +84,14 @@ def classify_records(self, full=False, start_date_time=None):
 
             if len(frbrized_records) >= window_size:
                 self.classified_count += len(frbrized_records)
-
                 self.bulkSaveObjects(frbrized_records)
 
                 frbrized_records = []
 
+        if len(frbrized_records):
+            self.classified_count += len(frbrized_records)
+            self.bulkSaveObjects(frbrized_records)
+
     def frbrize_record(self, record: Record):
         queryable_ids = self._get_queryable_identifiers(record.identifiers)
 

diff --git a/tests/unit/processes/frbr/test_classify_process.py b/tests/unit/processes/frbr/test_classify_process.py
@@ -143,7 +143,7 @@ def test_classify_records_full(self, test_instance, mocker):
         mock_start_time.timedelta.assert_not_called()
         mock_window_query.assert_called_once()
         mock_frbrize_record.assert_has_calls([mocker.call(record) for record in mock_records[:50]])
-        mock_bulk_save_objects.assert_not_called()
+        mock_bulk_save_objects.assert_called_once()
 
     def test_classify_records_full_batch(self, test_instance, mocker):
         mock_frbrize_record = mocker.patch.object(ClassifyProcess, 'frbrize_record')