SFR-1828_APIS3ObjectLink #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitri-slory
commented
Dec 20, 2023
mitri-slory
commented
Dec 20, 2023
Apophenia
requested changes
Dec 21, 2023
Co-authored-by: Lyndsey M. <[email protected]>
Apophenia
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new API that returns the a unique presigned url for S3 objects from the DRB buckets on AWS. The first commit I made to this PR has changes to the API and tests that are outdated now which I explain in the comments below. However, the first PR includes changes I made to swagger and other files which I recommend to look over as well for feedback.