Add fulfill route and tests #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitri-slory
reviewed
Dec 22, 2023
Comment on lines
+36
to
+45
| except jwt.exceptions.ExpiredSignatureError: | ||
| statusCode = 401 | ||
| responseBody = 'Expired access token' | ||
| except (jwt.exceptions.DecodeError, UnicodeDecodeError, IndexError, AttributeError): | ||
| statusCode = 401 | ||
| responseBody = 'Invalid access token' | ||
| except ValueError: | ||
| logger.warning("Could not deserialize NYPL-issued public key") | ||
| statusCode = 500 | ||
| responseBody = 'Server error' |
There was a problem hiding this comment.
Good to catch all these exception cases
mitri-slory
reviewed
Dec 22, 2023
Comment on lines
+51
to
+52
| MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA44ilHg/PxcJYsISHMRyoxsmez178qZpkJVXg7rOMVTLZuf05an7Pl+lX4nw/rqcvGQDXyrimciLgLkWu00xhm6h6klTeJSNq2DgseF8OMw2olfuBKq1NBQ/vC8U0l5NJu34oSN4/iipgpovqAHHBGV4zDt0EWSXE5xpnBWi+w1NMAX/muB2QRfRxkkhueDkAmwKvz5MXJPay7FB/WRjf+7r2EN78x5iQKyCw0tpEZ5hpBX831SEnVULCnpFOcJWMPLdg0Ff6tBmgDxKQBVFIQ9RrzMLTqxKnVVn2+hVpk4F/8tMsGCdd4s/AJqEQBy5lsq7ji1B63XYqi5fc1SnJEQIDAQAB | ||
| -----END PUBLIC KEY----- |
There was a problem hiding this comment.
This is a good addition to the sample compose file for the local environment.
mitri-slory
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
The new endpoint looks really good. The logic in the blueprint is fine since some of the other blueprints have a lot of logic as well when calling methods. I would only recommend finishing the rest of the tests you want to implement before fully merging this branch into main.
|
I'm going to go ahead and merge this, and add the one test I think I'm missing (need to mock an exception thrown for an expired token) with my next PR so that it can be reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not have 100% test coverage; when everything is hooked up I will add test cases for the positive cases of "yes, this is working" and also figure out how to mock the expired token.
Don't love how much logic lives directly in the Blueprint but given the error structure I'm not sure how to best test it if I were to bundle the auth logic in another file, but open to refactoring.