SFR-1990_UpdateREADME #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitri-slory
approved these changes
Jun 7, 2024
Apophenia
reviewed
Jun 7, 2024
README.md
Outdated
| - RabbitMQ | ||
| - Redis | ||
| - XCode Command Line Tools | ||
|
|
||
| This is a Python application and requires Python >= 3.6. It is recommended that a virtual environment be set up for the application (again use the virtual environment tool of your choice). | ||
| This is a Python application and requires Python >= 3.6. It is recommended that a virtual environment be set up for the application (again use the virtual environment tool of your choice). There are several options, but most developers use [virtualenv](https://virtualenv.pypa.io/en/latest/installation.html#). |
There was a problem hiding this comment.
It's true that virtualenv is probably still more widely used, and I don't object to this addition, but the Python-maintained venv module introduced in 3.3 (and recommended as of 3.5) does seem to work for this repo and I've used it successfully for all of DRB and PJR's repositories without installing another virtual environment manager.
There was a problem hiding this comment.
I'll add it to the recommendations!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After going through the installation process for drb-etl-pipeline, I have updated the README accordingly based on steps that have changed or require more information to complete.