Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2413: Migrate edition endpoint to use plural noun #481

Merged
merged 1 commit into from
Dec 19, 2024
Merged

SFR-2413: Migrate edition endpoint to use plural noun #481

merged 1 commit into from
Dec 19, 2024

Conversation

kylevillegas93
Copy link
Contributor

Description

  • Migrates edition endpoint to use plural noun

Testing

docker compose up and hit the endpoint /editions

mitri-slory
mitri-slory approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@mitri-slory mitri-slory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I would like to ask what is the motivation for adding this alternative edition endpoint? Is it to allow users and patrons to use either endpoint based on how they interpret the endpoint?

@kylevillegas93 kylevillegas93 merged commit 50b1f7f into main Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitri-slory mitri-slory mitri-slory approved these changes

@jackiequach jackiequach Awaiting requested review from jackiequach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @mitri-slory