Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SFR-2434] Simplifying delete record implementation #491

Merged
merged 21 commits into from
Dec 24, 2024
Merged

[SFR-2434] Simplifying delete record implementation #491

merged 21 commits into from
Dec 24, 2024
+212 −222

Conversation

kylevillegas93
Copy link
Contributor

@kylevillegas93 kylevillegas93 commented Dec 23, 2024 •
edited
Loading

Description

  • Fixes a few bugs to get the backlist project working as expected
  • Updates the delete logic to delete by items then editions and then works
  • Still needs some refactoring - I think that I can get it to be cleaner

Testing

  • Tested ingesting and clustering a record
  • Tested deleting a record

@Apophenia
Copy link
Contributor

looking good so far - I think i'll have to shuffle some things around on my upload branch but it should be ok, but i'll wait to open it until this is merged.

@kylevillegas93 kylevillegas93 marked this pull request as ready for review December 23, 2024 22:48
Apophenia
Apophenia approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@Apophenia Apophenia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! It's a lot easier to read the Airtable logic without the encoding inline.

Apophenia
Apophenia reviewed Dec 24, 2024
View reviewed changes
services/sources/publisher_backlist_service.py Outdated
from model import Record, Work, Edition, Item, Link
from model import Record, Work, Edition, Item
from sqlalchemy.orm import joinedload
from urllib.parse import urlparse
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably possible to just change this instance to be the same access pattern as the other urllib.parse usages

@kylevillegas93 kylevillegas93 merged commit b9c2b63 into main Dec 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apophenia Apophenia Apophenia approved these changes

@jackiequach jackiequach Awaiting requested review from jackiequach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @Apophenia