Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2741: Run CI via Github Actions #505

Merged
merged 8 commits into from
Jan 13, 2025
Merged

SFR-2741: Run CI via Github Actions #505

merged 8 commits into from
Jan 13, 2025

Conversation

kylevillegas93
Copy link
Contributor

@kylevillegas93 kylevillegas93 commented Jan 9, 2025 •
edited
Loading

Description

  • Run CI via Github Actions
  • This first pass runs the API tests that run against QA
  • Making a few changes to load different env variables depending on the environment
  • There's going to be some additional work to get all of the tests running in the QA environment

jackiequach
jackiequach reviewed Jan 13, 2025
View reviewed changes
.github/workflows/ci.yaml Outdated
AWS_SECRET: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
ENVIRONMENT: qa
steps:
- uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use checkout@v4 since v2 is running on a deprecated version of node.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - upgrading!

.github/workflows/ci.yaml Outdated
with:
python-version: '3.9'
- name: Cache dependencies
uses: actions/cache@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cache@v2 will be deprecated next month

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooop upgrading!

@kylevillegas93 kylevillegas93 merged commit 88b66eb into main Jan 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackiequach jackiequach jackiequach approved these changes

@ayan1229 ayan1229 Awaiting requested review from ayan1229

@Apophenia Apophenia Awaiting requested review from Apophenia

@mitri-slory mitri-slory Awaiting requested review from mitri-slory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylevillegas93 @jackiequach