TGR-152: PHP 8 update #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r into php8-update
… param has no default value.
…ency. Updates code to use new classes. Applies patch to match the forked changes previously made by Kevin Friedman.
…or composer subdepencies.
…poser nested dependencies.
nonword
reviewed
Jan 3, 2025
| @@ -0,0 +1 @@ | |||
| This is a fork of https://github.com/nealio82/avro-php. Changes were made to allow schema arrays to have integer keys. | |||
There was a problem hiding this comment.
Can we note the specific version you copied in? And where/how you patched? We maybe also want to link to this README from the top-level README.
| @@ -43,7 +43,7 @@ protected static function setCachedString($type = '', $originalString = '', $str | |||
| * | |||
| * @return string | |||
| */ | |||
| protected static function runStringy($type = '', $string = '', callable $stringy) | |||
| protected static function runStringy($type, $string, callable $stringy) | |||
There was a problem hiding this comment.
Defaults removed because they're enforced elsewhere or we want things to fail when the params are null?
| @@ -47,12 +47,12 @@ public static function initialize($configDirectory = '') | |||
| */ | |||
| public static function get($name = '', $defaultValue = null, $isEncrypted = false) | |||
| { | |||
| if (getenv($name) !== false) { | |||
| if (!empty($_ENV[$name])) { | |||
There was a problem hiding this comment.
Does this not raise a warning/error if $name isn't set in $_ENV?
| @@ -155,7 +155,7 @@ protected static function loadConfiguration() | |||
| } | |||
|
|
|||
| if (file_exists(self::getConfigDirectory() . '/' . self::GLOBAL_ENVIRONMENT_FILE)) { | |||
| $dotEnv = new Dotenv(self::getConfigDirectory(), self::GLOBAL_ENVIRONMENT_FILE); | |||
| $dotEnv = Dotenv::createImmutable(self::getConfigDirectory(), self::GLOBAL_ENVIRONMENT_FILE); | |||
There was a problem hiding this comment.
Just curious - are we intentionally using Immutable over Mutable because there are specific env vars we anticipate that we don't want to overwrite?
| public function __construct() | ||
| public function __construct( | ||
| InjectionFactory $injectionFactory, | ||
| ContainerInterface $delegateContainer = null) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to update the code to work with PHP 8.3.
Slim - This framework library needed to be upgraded from v3 to v4 for PHP 8 compatibility. This required many changes to the codebase to implement its API changes. The Aura/DI library was also added since the new version of Slim requires it.
Swagger PHP - the dependent library changed its name from Swagger to OpenAPI, so docblock comments have been changed from SWG to OA.
Avro PHP - this library was forked from version 1.8.1 and the files were included in this repo. The modifications were just a few simple changes that allowed schema arrays to have integers for keys. The base version, 1.8.1 was only compatible with PHP 5.3, so I got a newer version from https://github.com/nealio82/avro-php and made the same modifications and placed it in the lib folder. I was hoping to use Composer to include the new Avro dependency and use a patch for the modifications, but since the PHP Microservice Starter is itself used as a Composer dependency, it isn't allowed have patches on its own dependencies.
Updated Libraries:
slim/slim: 3.5.0 => 4.14.0
slim/pdo: 1.9.9 => faapz/pdo 2.2.0
monolog/monolog: 1.23.0 => 3.7.0
danielstjules/stringy: 2.3.2 => 3.1
zircote/swagger-php: 2.0.7 => 4.10.6
aws/aws-sdk-php: 3.31.4 => 3.319.4
vlucas/phpdotenv: 2.4.0 => 5.6.1
guzzlehttp/guzzle: 6.2.3 => 7.9.2