Scc 4327 #97
Merged
Scc 4327 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve handling fetch errors - Improve test coverage around error conditions - Replace axios with fetch - Generally tighten mocking of nypl-source-mapper requests https://newyorkpubliclibrary.atlassian.net/browse/SCC-4327
charmingduchess
requested changes
Oct 28, 2024
| expect(callCount).to.equal(1) | ||
| expect(mapping.nyplSourceMap).to.nested.include({ 'sierra-nypl.organization': 'nyplOrg:0001' }) | ||
|
|
||
| // Trigger another instance creation, which will break if another `fetch` |
There was a problem hiding this comment.
I'd love to see this as an explicit assertion rather than implicit in the setup of the nock. Can you replace the callback counter from the original testing setup?
There was a problem hiding this comment.
Sure thing. Added a counter and updated test to make explicit assertions about counts throughout this test.
charmingduchess
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://newyorkpubliclibrary.atlassian.net/browse/SCC-4327