Remove optional chaining in DRB and add underline overrides

NYPL · Oct 26, 2023 · 13a5408 · 13a5408
1 parent 5751417
commit 13a5408
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/src/components/DRB/DRBCard.tsx b/src/components/DRB/DRBCard.tsx
@@ -19,14 +19,9 @@ interface DRBCardProps {
  */
 const DRBCard = ({ drbResult }: DRBCardProps) => {
   return (
-    <Card
-      backgroundColor="var(--nypl-colors-ui-bg-default)"
-      sx={{
-        padding: "var(--nypl-space-xs)",
-      }}
-    >
+    <Card backgroundColor="var(--nypl-colors-ui-bg-default)" p="xs">
       <CardContent>
-        <DSLink href={drbResult.url} target="_blank">
+        <DSLink href={drbResult.url} target="_blank" isUnderlined={false}>
           <Text size="body2">{drbResult.title}</Text>
         </DSLink>
 
@@ -44,19 +39,24 @@ const DRBCard = ({ drbResult }: DRBCardProps) => {
           </Text>
         )}
 
-        {drbResult?.readOnlineUrl && (
+        {drbResult.readOnlineUrl && (
           <DSLink
             href={drbResult.readOnlineUrl}
             target="_blank"
             type="buttonPrimary"
-            mb={drbResult?.downloadLink ? "s" : ""}
+            mb={drbResult.downloadLink ? "s" : ""}
+            isUnderlined={false}
           >
             Read Online
           </DSLink>
         )}
 
-        {drbResult?.downloadLink && (
-          <DSLink href={drbResult.downloadLink.url} target="_blank">
+        {drbResult.downloadLink && (
+          <DSLink
+            href={drbResult.downloadLink.url}
+            target="_blank"
+            isUnderlined={false}
+          >
             <Text
               size="body2"
               sx={{ display: "flex", alignItems: "center" }}

diff --git a/src/components/SearchResult/SearchResult.tsx b/src/components/SearchResult/SearchResult.tsx
@@ -25,8 +25,10 @@ const SearchResult = ({ bib }: SearchResultProps) => {
         paddingBottom: "m",
       }}
     >
-      <CardHeading level="h3">
-        <DSLink href={`${PATHS.BIB}/${bib.id}`}>{bib.title}</DSLink>
+      <CardHeading level="h3" size="heading4">
+        <DSLink href={`${PATHS.BIB}/${bib.id}`} isUnderlined={false}>
+          {bib.title}
+        </DSLink>
       </CardHeading>
       <CardContent>
         <Box sx={{ p: { display: "inline", marginRight: "s" } }}>