Fix errors

NYPL · Nov 22, 2024 · 1c81830 · 1c81830
1 parent 1393182
commit 1c81830
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/pages/hold/confirmation/[id].tsx b/pages/hold/confirmation/[id].tsx
@@ -66,6 +66,7 @@ export default function HoldConfirmationPage({
 }
 
 export async function getServerSideProps({ req, res, query }) {
+  const { pickupLocation, requestId } = query
   // authentication redirect
   const patronTokenResponse = await initializePatronTokenAuth(req.cookies)
   const isAuthenticated = patronTokenResponse.isTokenValid
@@ -82,7 +83,10 @@ export async function getServerSideProps({ req, res, query }) {
         redirectCount + 1
       }; Max-Age=10; path=/; domain=.nypl.org;`
     )
-    const redirect = getLoginRedirect(req, `${PATHS.HOLD_REQUEST}/${id}/edd`)
+    const redirect = getLoginRedirect(
+      req,
+      `${PATHS.HOLD_CONFIRMATION}?pickupLocation=${pickupLocation}&requestId=${requestId}`
+    )
 
     return {
       redirect: {
@@ -93,7 +97,6 @@ export async function getServerSideProps({ req, res, query }) {
   }
 
   const patronId = patronTokenResponse?.decodedPatron?.sub
-  const { pickupLocation, requestId } = query
 
   try {
     const { patronId: patronIdFromResponse } = await fetchHoldDetails(requestId)

diff --git a/src/types/holdPageTypes.ts b/src/types/holdPageTypes.ts
@@ -26,6 +26,7 @@ export interface HoldPostResult {
   pickupLocation?: NYPLocationKey | "edd"
   formInvalid?: boolean
   requestId?: string
+  errorMessage?: string
 }
 
 export interface HoldDetailsResult {