fix extent biz

NYPL · Nov 25, 2024 · 25f07b2 · 25f07b2
1 parent e916971
commit 25f07b2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/__test__/pages/bib/bibPage.test.tsx b/__test__/pages/bib/bibPage.test.tsx
@@ -45,7 +45,7 @@ describe("Bib Page with items", () => {
   })
 
   // TODO: Determine if this should be rendering twice
-  it("renders the bottom bib details", () => {
+  it.only("renders the bottom bib details", () => {
     expect(screen.getAllByTestId("publication-date")[0]).toHaveTextContent(
       "Vol. 1, issue 1-"
     )

diff --git a/src/models/BibDetails.ts b/src/models/BibDetails.ts
@@ -106,8 +106,6 @@ export default class BibDetails {
             return this.supplementaryContent
           case "creatorLiteral":
             return this.buildInternalLinkedDetail(fieldMapping)
-          case "owner":
-            return this.owner
           default:
             return this.buildStandardDetail(fieldMapping)
         }
@@ -186,7 +184,7 @@ export default class BibDetails {
 
   buildStandardDetail(fieldMapping: FieldMapping) {
     const bibFieldValue =
-      this.bib[fieldMapping.field] || this[fieldMapping.field]
+      this[fieldMapping.field] || this.bib[fieldMapping.field]
     if (!bibFieldValue) return
     return this.buildDetail(
       convertToSentenceCase(fieldMapping.label),
@@ -355,7 +353,6 @@ export default class BibDetails {
       parts.push(dimensions[0])
       modifiedExtent = [parts.join("; ")]
     }
-
     return modifiedExtent
   }
 

diff --git a/src/models/modelTests/BibDetails.test.ts b/src/models/modelTests/BibDetails.test.ts
@@ -166,7 +166,7 @@ describe("Bib model", () => {
       )
     })
   })
-  xdescribe("extent", () => {
+  describe("extent", () => {
     it("should add a semicolon after extent if there is not one already", () => {
       const bib = new BibDetailsModel({
         identifier: [{ uri: "123456" }],