Rename holdRequestSource to formattedSourceForHoldRequest

pages/hold/request/[id]/edd.tsx

@@ -74,7 +74,7 @@ export default function EDDRequestPage({
   const [eddFormState, setEddFormState] = useState({
     ...initialEDDFormState,
     patronId,
-    source: item.holdRequestSource,
+    source: item.formattedSourceForHoldRequest,
   })
   const [formPosting, setFormPosting] = useState(false)
 

pages/hold/request/[id]/index.tsx

@@ -180,7 +180,7 @@ export default function HoldRequestPage({
               handleSubmit={handleSubmit}
               holdId={holdId}
               patronId={patronId}
-              source={item.holdRequestSource}
+              source={item.formattedSourceForHoldRequest}
             />
           </>
         ) : null}

src/models/Item.ts

@@ -82,7 +82,7 @@ export default class Item {
       .includes("all")
   }
 
-  get holdRequestSource(): string {
+  get formattedSourceForHoldRequest(): string {
     return convertCamelToShishKabobCase(this.source)
   }
 

src/models/modelTests/Item.test.ts

@@ -106,7 +106,7 @@ describe("Item model", () => {
     })
 
     it("returns the source in kebabcase for use in hold requests", () => {
-      expect(item.holdRequestSource).toBe("sierra-nypl")
+      expect(item.formattedSourceForHoldRequest).toBe("sierra-nypl")
     })
   })