Merge pull request #377 from NYPL/SCC-4260/vqa

Hotfix changes
NYPL · Oct 23, 2024 · 5d4c6bb · 5d4c6bb
2 parents 5d2b923 + 713aec9
commit 5d4c6bb
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 23 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -5,7 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## Prerelease
+## 1.3.5 2024-10-23
+
+### Updated
+
+- Create banner container in Layout component and add EDS link to that container (SCC-4260)
+- Sentence case and rearrange search options (SCC-4260)
+- Call number search scope to search dropdown options [(SCC-4260)](https://newyorkpubliclibrary.atlassian.net/browse/SCC-4260)
+- Search tip per search scope [(SCC-4263)](https://newyorkpubliclibrary.atlassian.net/browse/SCC-4263)
 
 ### Fixed
 ### [1.3.4] Hotfix 2024-10-17
@@ -49,15 +56,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Updated
 
-- Create banner container in Layout component and add EDS link to that container (SCC-4260)
 - Bump DS version to 3.4.0
 - Bump nvmrc version to Node 20.
 - Update error message in Item Filter Year to include new error message prefix from the DS.
 - Integrate view_all query param on client side and remove batched fetch (SCC-4287)
 - Replaced travis with github actions (SCC-4218)
-- Sentence case and rearrange search options (SCC-4260)
-- Call number search scope to search dropdown options [(SCC-4260)](https://newyorkpubliclibrary.atlassian.net/browse/SCC-4260)
-- Search tip per search scope [(SCC-4263)](https://newyorkpubliclibrary.atlassian.net/browse/SCC-4263)
 
 ## [1.2.4] 2024-08-29
 

diff --git a/src/components/EDSBanner.tsx b/src/components/EDSBanner.tsx
@@ -1,4 +1,4 @@
-import { Text, Banner } from "@nypl/design-system-react-components"
+import { Banner } from "@nypl/design-system-react-components"
 import ExternalLink from "./Links/ExternalLink/ExternalLink"
 import React from "react"
 
@@ -13,19 +13,19 @@ const EDSBanner = () => {
       className={styles.banner}
       type="informative"
       content={
-        <Text sx={{ marginBottom: 0 }}>
+        <>
           <span style={{ color: "var(--nypl-colors-ui-success-primary)" }}>
             New!
           </span>{" "}
           Try our{" "}
           <ExternalLink href="https://discovery.ebsco.com/c/tvrejk?acr_values=guest">
-            <strong style={{ color: "var(--nypl-colors-ui-link-primary" }}>
+            <b style={{ color: "var(--nypl-colors-ui-link-primary" }}>
               Article Search
-            </strong>
+            </b>
           </ExternalLink>{" "}
           to discover online journals, books, and more from home with your
           library card.
-        </Text>
+        </>
       }
     />
   )

diff --git a/src/components/Layout/Layout.tsx b/src/components/Layout/Layout.tsx
@@ -80,24 +80,23 @@ const Layout = ({
                 />
                 {showSearch && <SearchForm aggregations={searchAggregations} />}
               </div>
-              {showNotification && bannerNotification && (
-                <Flex
-                  gap="var(--nypl-space-l)"
-                  align="center"
-                  // justify="space-around"
-                  direction="column"
-                  sx={{
-                    padding: "2em 2em .5em 2em",
-                  }}
-                >
-                  <EDSBanner />
+              <Flex
+                gap="l"
+                align="center"
+                direction="column"
+                sx={{
+                  padding: "2em 2em .5em 2em",
+                }}
+              >
+                <EDSBanner />
+                {showNotification && bannerNotification && (
                   <Banner
                     className={styles.banner}
                     heading="New Service Announcement"
                     content={bannerNotification}
                   />
-                </Flex>
-              )}
+                )}
+              </Flex>
             </>
           )
         }