Move urls to Heading component props to remove underlines

NYPL · Oct 30, 2023 · 6004229 · 6004229
1 parent a5be13e
commit 6004229
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 15 deletions.
diff --git a/pages/index.tsx b/pages/index.tsx
@@ -63,8 +63,8 @@ export default function Home() {
             }}
             layout="row"
           >
-            <CardHeading level="h4">
-              <Link href="/research/collections">Collections</Link>
+            <CardHeading level="h4" url="/research/collections">
+              Collections
             </CardHeading>
             <CardContent>
               <p>
@@ -82,8 +82,8 @@ export default function Home() {
             }}
             layout="row"
           >
-            <CardHeading level="h4">
-              <Link href="/locations/map?libraries=research">Locations</Link>
+            <CardHeading level="h4" url="/locations/map?libraries=research">
+              Locations
             </CardHeading>
             <CardContent>
               <p>
@@ -101,8 +101,8 @@ export default function Home() {
             }}
             layout="row"
           >
-            <CardHeading level="h4">
-              <Link href="/about/divisions">Divisions</Link>
+            <CardHeading level="h4" url="/about/divisions">
+              Divisions
             </CardHeading>
             <CardContent>
               <p>
@@ -120,8 +120,8 @@ export default function Home() {
             }}
             layout="row"
           >
-            <CardHeading level="h4">
-              <Link href="/research/support">Support</Link>
+            <CardHeading level="h4" url="/research/support">
+              Support
             </CardHeading>
             <CardContent>
               <p>
@@ -139,8 +139,8 @@ export default function Home() {
             }}
             layout="row"
           >
-            <CardHeading level="h4">
-              <Link href="/research/services">Services</Link>
+            <CardHeading level="h4" url="/research/services">
+              Services
             </CardHeading>
             <CardContent>
               <p>

diff --git a/src/components/DRB/DRBCard.tsx b/src/components/DRB/DRBCard.tsx
@@ -31,7 +31,11 @@ const DRBCard = ({ drbResult }: DRBCardProps) => {
             {drbResult.authors.map((author: Author | Agent, index: number) => (
               <>
                 {index > 0 && ","}
-                <DSLink href={getAuthorURL(author)} target="_blank">
+                <DSLink
+                  href={getAuthorURL(author)}
+                  target="_blank"
+                  isUnderlined={false}
+                >
                   {author.name}
                 </DSLink>
               </>

diff --git a/src/components/SearchResult/SearchResult.tsx b/src/components/SearchResult/SearchResult.tsx
@@ -25,10 +25,8 @@ const SearchResult = ({ bib }: SearchResultProps) => {
         paddingBottom: "m",
       }}
     >
-      <CardHeading level="h3" size="heading4">
-        <DSLink href={`${PATHS.BIB}/${bib.id}`} isUnderlined={false}>
-          {bib.title}
-        </DSLink>
+      <CardHeading level="h3" size="heading4" url={`${PATHS.BIB}/${bib.id}`}>
+        {bib.title}
       </CardHeading>
       <CardContent>
         <Box sx={{ p: { display: "inline", marginRight: "s" } }}>