Restore null check on patron ID for tests

NYPL · Dec 16, 2024 · 8b9e05b · 8b9e05b
1 parent 6d90c08
commit 8b9e05b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/pages/api/hold/request/[id]/edd.ts b/pages/api/hold/request/[id]/edd.ts
@@ -40,8 +40,9 @@ async function handler(req: NextApiRequest, res: NextApiResponse) {
     }
 
     const holdRequestResponse = await postEDDRequest({
-      ...rest,
       itemId,
+      patronId,
+      ...rest,
     })
 
     const { requestId } = holdRequestResponse

diff --git a/pages/hold/request/[id]/edd.tsx b/pages/hold/request/[id]/edd.tsx
@@ -248,7 +248,7 @@ export async function getServerSideProps({ params, req, res }) {
       console.error("EDD Page - Error fetching edd in getServerSideProps")
     }
 
-    const isEddAvailable = eddRequestable && item.isAvailable
+    const isEddAvailable = eddRequestable && item.isEDDRequestable
 
     const patronEligibilityStatus = await fetchPatronEligibility(patronId)
 
@@ -262,6 +262,7 @@ export async function getServerSideProps({ params, req, res }) {
         discoveryItemResult,
         patronId,
         isAuthenticated,
+        patronEligibilityStatus,
         errorStatus: locationOrEligibilityFetchFailed
           ? "failed"
           : patronEligibilityStatus.status === 401

diff --git a/pages/hold/request/[id]/index.tsx b/pages/hold/request/[id]/index.tsx
@@ -94,7 +94,7 @@ export default function HoldRequestPage({
       const response = await fetch(`${BASE_URL}/api/hold/request/${holdId}`, {
         method: "POST",
         body: JSON.stringify({
-          patronId: patronId.value,
+          patronId: patronId?.value,
           source: source?.value,
           pickupLocation: pickupLocation?.value,
           jsEnabled: true,