SCC-3742 - Upgrade DS version and update heading props #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EdwinGuzman
approved these changes
Oct 27, 2023
* SCC-3742: Move urls to Heading component props to remove underlines Move urls to Heading component props to remove underlines Replace sx props with _css Remove optional chaining in DRB and add underline overrides Override visited link style in subnav Update DS version and update heading keys
SCC-2839: Homepage a11y updates
charmingduchess
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Design System library version to 2.1.0 and replaces the heading level key values with the new element-based keys (h1, h2 etc).
It also includes a couple of minor miscellaneous changes, including removing optional chaining from theDRBCard component and replacing the sx prop with __css based on Marty's recommendation.
NB: The links are still appearing underlined in spite of the inUnderlined={false} prop. I'm currently working with Marty to figure out why this is happening.