HOTFIX - Fix analytics page tracking events #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…C-4369/fix-analytics-page-tracking-events
dgcohen
changed the title
EdwinGuzman
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for analytics bug where page routes without a query string were emitting a homepage view event. This was caused by the use of a -1 ending index in a substring function, which returns an empty string.
This was missed in QA for the bib release page, and I assume we didn't notice it when we released the search results because most routes have a query string.
There are no unit tests for trackVirtualPageView since it has a void return type, but I'll separate this logic out to add unit tests as a fast-follow.