SCC-3731 - Item Model #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/item-table-model
…/item-table-model
…catalog into SCC-3731/item-table-model
|
Looks good! Not sure if I'm not seeing the most updated code, but can we replace all instances of nonNypl with partner and nonRecap with onsite? |
…/item-table-model
…catalog into SCC-3731/item-table-model
EdwinGuzman
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Item class and the required param assigment/functions necessary for the Item table.
It also includes a couple of necessary constants for the ItemTable and some small miscellaneous fixes (util tests renamed, constant used for DRB url).