Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCC-4409: My Account 2.0 QA #3 #423

Merged
merged 2 commits into from
Dec 20, 2024
Merged

SCC-4409: My Account 2.0 QA #3 #423

merged 2 commits into from
Dec 20, 2024

Conversation

7emansell
Copy link
Contributor

@7emansell 7emansell commented Dec 19, 2024

Ticket:

This PR does the following:

QA:

  • When you click “Edit” after canceling a filled out password form, it allows the “Save Changes” button to be active even though the form is not currently valid. Resolve

VQA:

  • Info banner for None state needs to match width of the banner for username

How has this been tested?

The banner width update can only be seen on an account that has no attached phone number or email, and has its notification preference set to None. Use this one: 25555001351471 / 1082 but DO NOT actually Save Changes on an email/phone or on the notification preference :)

To test the password form, submit an incorrect password OR fill out the whole form correctly then click Cancel. When you reopen the form, the Save Changes button should be disabled.

Accessibility concerns or updates

Checklist:

  • I updated the CHANGELOG with the appropriate information and JIRA ticket number (if applicable).
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
research-catalog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 5:07pm

@7emansell 7emansell merged commit 626168b into main Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants