Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Account 2.0 QA round 4 #426

Merged
merged 4 commits into from
Jan 2, 2025
Merged

My Account 2.0 QA round 4 #426

merged 4 commits into from
Jan 2, 2025

Conversation

7emansell
Copy link
Contributor

@7emansell 7emansell commented Dec 20, 2024

Ticket:

This PR does the following:

  • Updates DS version to 3.5.1
  • Restores isClearable functionality to input fields

VQA:

  • Info banner moved up 8px

How has this been tested?

The banner update can only be seen on an account that has no attached phone number or email, and has its notification preference set to None. Use this one: 25555001351471 / 1082

To test isClearable, just clear any field to ensure the focus stays on that field

Accessibility concerns or updates

Checklist:

  • I updated the CHANGELOG with the appropriate information and JIRA ticket number (if applicable).
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
research-catalog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 8:05pm

@7emansell 7emansell changed the title My Account 2.0 QA round 4: 8px of padding My Account 2.0 QA round 4 Dec 20, 2024
Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an error with focusing after I click on the X button for both the username and phone/email inputs. I don't readily see where this is happening.

Screenshot 2024-12-20 at 4 09 46 PM

@EdwinGuzman EdwinGuzman self-requested a review December 20, 2024 21:12
@7emansell
Copy link
Contributor Author

I'm getting an error with focusing after I click on the X button for both the username and phone/email inputs. I don't readily see where this is happening.

Screenshot 2024-12-20 at 4 09 46 PM

I'm not seeing this... did you clean install

@charmingduchess
Copy link
Contributor

After fresh npm install, works well. Is the banner supposed to be flush with "None"? I'm seeing it right up against the text.

@7emansell
Copy link
Contributor Author

Yes it should be ~8px away like this:
image

@7emansell 7emansell merged commit e1fd0bd into main Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants