Code

Scc 4405/hold pages js disabled#429

Code

Merged

dgcohen merged 17 commits intohold-pagesNYPL/research-catalog:hold-pagesfrom SCC-4405/hold-pages-js-disabledNYPL/research-catalog:SCC-4405/hold-pages-js-disabledCopy head branch name to clipboardJan 6, 2025

+206-37

Commits

Commits on Jan 1, 2025

• Remove JSON parsing and fix hold confirmation url formatting

  dgcohen

  committed
  a74d002

  Copy full SHA for a74d002

Commits on Jan 2, 2025

• Get basic server-side validation working

  dgcohen

  committed
  e237bcd

  Copy full SHA for e237bcd

• Pass edd form state in query param

  dgcohen

  committed
  da67061

  Copy full SHA for da67061

• Set invalid status on failed server validation

  dgcohen

  committed
  034d04f

  Copy full SHA for 034d04f

• Fix server side req body parsing

  dgcohen

  committed
  75b883e

  Copy full SHA for 75b883e

• Add query getServerSideProps params in test

  dgcohen

  committed
  b2c07c1

  Copy full SHA for b2c07c1

• Update comments

  dgcohen

  committed
  dc031f0

  Copy full SHA for dc031f0

• Add test for default invalid status

  dgcohen

  committed
  885f17f

  Copy full SHA for 885f17f

• Add test for validation in query param

  dgcohen

  committed
  cdc4e36

  Copy full SHA for cdc4e36

• Add tests for form prepopulation

  dgcohen

  committed
  a20ef5b

  Copy full SHA for a20ef5b

• Update changelog

  dgcohen

  committed
  cc28efe

  Copy full SHA for cc28efe

• Rename invalidFields to validatedFields

  dgcohen

  committed
  fdb4c81

  Copy full SHA for fdb4c81

• Add tests for other fields

  dgcohen

  committed
  ca2668a

  Copy full SHA for ca2668a

• Change patron email in test to test overriding

  dgcohen

  committed
  59eae2e

  Copy full SHA for 59eae2e

• Remove unused prop

  dgcohen

  committed
  406169e

  Copy full SHA for 406169e

Commits on Jan 3, 2025

• Encode redirect uri

  dgcohen

  committed
  a6177a0

  Copy full SHA for a6177a0

• Fix query string

  dgcohen

  committed
  85b6e48

  Copy full SHA for 85b6e48